Skip to content

Ingest Zhang 2018#671

Merged
ying2212 merged 6 commits intoSIMPLE-AstroDB:mainfrom
ying2212:ingest-zhang18
Mar 17, 2026
Merged

Ingest Zhang 2018#671
ying2212 merged 6 commits intoSIMPLE-AstroDB:mainfrom
ying2212:ingest-zhang18

Conversation

@ying2212
Copy link
Copy Markdown
Member

@ying2212 ying2212 commented Mar 3, 2026

Short description: Fix simple.yaml to add mode as PK in spectra table and JSON ingestion for Zhang18.

Link to relevant issue: Closes #

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@ying2212 ying2212 marked this pull request as draft March 3, 2026 18:33
@kelle
Copy link
Copy Markdown
Collaborator

kelle commented Mar 3, 2026

Fixes made in astrodb_utils v1.3 to make this possible.

@kelle
Copy link
Copy Markdown
Collaborator

kelle commented Mar 4, 2026

schema updated in #674 to work with astrodb_utils functions.

@ying2212 ying2212 marked this pull request as ready for review March 4, 2026 22:59
@kelle
Copy link
Copy Markdown
Collaborator

kelle commented Mar 4, 2026

For the 14 sources, are the spectral types easily findable somewhere in the Zhang papers?

@kelle
Copy link
Copy Markdown
Collaborator

kelle commented Mar 4, 2026

We also need to double check the discovery references for these 14 new sources.

@ying2212
Copy link
Copy Markdown
Member Author

ying2212 commented Mar 5, 2026

For the 14 sources, are the spectral types easily findable somewhere in the Zhang papers?

Yes! their spectral types are all listed in Table 2 of the Zhang paper (linked here). I also checked on SIMBAD and the references all point to the Zhang papers for these 14 sources

@kelle
Copy link
Copy Markdown
Collaborator

kelle commented Mar 17, 2026

Discovery refs confirmed to be Zhang18. Spectral types found, one found to be an M6 and not needed in SIMPLE. Add those 13 spectral types to this PR.

Copy link
Copy Markdown
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ying2212 ying2212 merged commit 77b457d into SIMPLE-AstroDB:main Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants